Skip to content

Remove redundant pretest build from CI test job#917

Merged
hotlong merged 2 commits intomainfrom
copilot/optimize-ci-test-duration
Feb 28, 2026
Merged

Remove redundant pretest build from CI test job#917
hotlong merged 2 commits intomainfrom
copilot/optimize-ci-test-duration

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 28, 2026

CI test job takes ~9 min. Breakdown: ~1.5 min pretest:coverage turbo build + ~7.5 min vitest run. The build is unnecessary — vitest.config.mts resolves all @object-ui/* imports to source via path aliases, never touching dist/.

  • Remove pretest:coverage — eliminates turbo run build of 11 packages that produced artifacts no test ever consumed
  • Skip HTML coverage in CI — override reporters to json + text only; HTML report is generated but never uploaded or viewed
Original prompt

ci test 时间太长了,大概有9分钟评估是否能够优化和简化


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectui Ready Ready Preview, Comment Feb 28, 2026 0:20am
objectui-demo Ready Ready Preview, Comment Feb 28, 2026 0:20am
objectui-storybook Ready Ready Preview, Comment Feb 28, 2026 0:20am

Request Review

…in CI

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Evaluate optimization for lengthy CI test duration Remove redundant pretest build from CI test job Feb 28, 2026
@hotlong hotlong marked this pull request as ready for review February 28, 2026 13:23
Copilot AI review requested due to automatic review settings February 28, 2026 13:23
@hotlong hotlong merged commit 113ccde into main Feb 28, 2026
4 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unnecessary build step from the CI test workflow by relying on Vitest’s existing @object-ui/* source-path aliasing, and trims CI coverage output to the reporters that are actually consumed.

Changes:

  • Deleted the implicit pretest:coverage hook that ran a Turbo build before test:coverage.
  • Updated CI to run coverage with json + text reporters only (skipping unused HTML generation).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Removes pretest:coverage so pnpm test:coverage no longer triggers a redundant Turbo build.
.github/workflows/ci.yml Overrides Vitest coverage reporters in CI to json + text for faster runs and smaller artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants